Skip to content

fix: step "Check for changes since last nightly" needs to run before "Determine version and channel"#214

Merged
soul2zimate merged 4 commits into
redhat-developer:mainfrom
soul2zimate:script_fix_main
Sep 5, 2025
Merged

fix: step "Check for changes since last nightly" needs to run before "Determine version and channel"#214
soul2zimate merged 4 commits into
redhat-developer:mainfrom
soul2zimate:script_fix_main

Conversation

@soul2zimate

Copy link
Copy Markdown
Contributor

steps.changes_check.outputs.has_changes needs to be evaluated first.

fix: step "Check for changes since last nightly" needs to run before "Determine version and channel"

chore: add some validations and logging information

@soul2zimate
soul2zimate requested a review from ruromero September 4, 2025 06:15

@ruromero ruromero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you mind adding that the action only runs on the redhat-developer/intellij-dependency-analytics repository? I forgot to add it.
Thanks

@sonarqubecloud

sonarqubecloud Bot commented Sep 4, 2025

Copy link
Copy Markdown

@soul2zimate

Copy link
Copy Markdown
Contributor Author

Looks good. Do you mind adding that the action only runs on the redhat-developer/intellij-dependency-analytics repository? I forgot to add it. Thanks

sure, I have added that condition

@ruromero

ruromero commented Sep 4, 2025

Copy link
Copy Markdown
Collaborator

Thank you!

@soul2zimate
soul2zimate merged commit aebbf39 into redhat-developer:main Sep 5, 2025
8 checks passed
@soul2zimate
soul2zimate deleted the script_fix_main branch September 5, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants